-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for cortex-m-rt 0.7.5 #533
Conversation
Before we do the releases, have we checked that the new macro works as expected and rejects mismatched hard fault signatures? |
Tests were added: https://github.com/rust-embedded/cortex-m/blob/master/cortex-m-rt/tests/compile-fail/hard-fault-bad-signature-3.rs It doesn't pick up on unreleased macro crate releases because it defines the dependency with a path: cortex-m/cortex-m-rt/Cargo.toml Lines 21 to 22 in 4395bae
This is probably the correct way in this crate, but yeah it does make it easy to forget to release any new version of it. |
I think one solution for this is for the main branch to be changed to have the version number |
Also noting that @newAM successfully yanked v0.7.4 - we should probably note this in the release docs that we are fixing those regression(s). |
I rebased this branch to fix CI and resolve conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed that this PR got blocked awaiting a review after thejpster left as a member. I'm not sure how to evaluate the risk of #535, will wait for other cortex-m members to help evaluate that.
690528c
to
14772b4
Compare
I've rebased and updated the changelog with the various changes. Should be ready to go now. |
Fixes #532.