Allow up to 496 interrupts on ARMv8-M #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgreig
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Thanks, looks good! Just noting that this changes the size of the generated interrupt table (thus taking up appreciably more flash) only when the device feature is not used, which is rare - for most people the table comes from the PAC and so this won't impact flash size. Instead it just stops cortex-m-rt rejecting perfectly valid device crates with lots of interrupts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran into this while trying to generate a PAC, this fixes #529 .
Not sure if it would be better to change the default value to 496 as well.