Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI after update of ubuntu and rust #562

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jannic
Copy link
Member

@jannic jannic commented Oct 18, 2024

The qemu package is no longer available. Fortunately, it's not really used by the CI script. It uses qemu-system-arm, which is also installed.

(See https://github.com/rust-embedded/cortex-m/actions/runs/11363980750/job/31609061545?pr=560 as an example for a pipeline failing without this fix.)

And nightly introduced some new lints that broke the build due to --deny warnings.

The qemu package is no longer available. Fortunately, it's not really
used by the CI script. It uses qemu-system-arm, which is also installed.
@jannic
Copy link
Member Author

jannic commented Oct 18, 2024

Well. That fixes one error. Unfortunately rust had a new release as well. CI hell!

@jannic jannic changed the title Fix CI on latest ubuntu Fix CI after update of ubuntu and rust Oct 18, 2024
@jannic
Copy link
Member Author

jannic commented Oct 18, 2024

The remaining failing CI check is already covered by #561

@adamgreig
Copy link
Member

Do we need this merged with 561 before either can be merged to master?

@jannic
Copy link
Member Author

jannic commented Oct 18, 2024

As I understand the CI pipeline, the check fixed in #561 is not marked as required and is therefore should not block merging #562.
If that doesn't work, I can of course merge the two fixes into a single pull request.

@adamgreig adamgreig added this pull request to the merge queue Oct 18, 2024
Merged via the queue into rust-embedded:master with commit 7ab06dd Oct 18, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants