Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in md document #82

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shengliang
Copy link

  • Fix typo in md document, missing "-".
  • Add +nightly example since examples need nightly build version.

@Shengliang Shengliang requested a review from a team as a code owner March 30, 2022 22:48
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Mar 30, 2022
@adamgreig
Copy link
Member

Thanks for the PR! The single-dash version of the arguments used to be correct but changed in a recent binutils release, so it's led to a lot of fixes like this being required!

For the rustup default, are you sure that's the right command? I thought either you want to ask rustup to install nightly (rustup install nightly) so that cargo +nightly build works, or maybe to use nightly by default (rustup default nightly) after installing it, but not to use nightly rustup to set the default to stable, which is what rustup +nightly default stable does:

$ rustup +nightly default stable
info: using existing install for 'stable-x86_64-unknown-linux-gnu'
info: default toolchain set to 'stable-x86_64-unknown-linux-gnu'

  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.59.0 (9d1b2106e 2022-02-23)

info: note that the toolchain 'nightly-x86_64-unknown-linux-gnu' is currently in use (overridden by +toolchain on the command line)

$ rustc --version
rustc 1.59.0 (9d1b2106e 2022-02-23)

@Shengliang
Copy link
Author

Shengliang commented Apr 12, 2022

rustup use "+nightly" to select nightly version dynamically.

The default rustc version does not work (that I faced), I have to use "nightly" version.
Hence, I added example to install nightly dependencies.

$ rustc -V
$ rustc +nightly -V

$ rustup target add thumbv7m-none-eabi
$ rustup +nightly target add thumbv7m-none-eabi

@Shengliang
Copy link
Author

Updated readme.

$ rustup default stable
info: using existing install for 'stable-x86_64-unknown-linux-gnu'
info: default toolchain set to 'stable-x86_64-unknown-linux-gnu'

stable-x86_64-unknown-linux-gnu unchanged - rustc 1.59.0 (9d1b2106e 2022-02-23)

$ rustc -V
rustc 1.59.0 (9d1b2106e 2022-02-23)
$ rustc +nightly -V
rustc 1.61.0-nightly (9c06e1ba4 2022-03-29)

$ rustup default nightly
info: using existing install for 'nightly-x86_64-unknown-linux-gnu'
info: default toolchain set to 'nightly-x86_64-unknown-linux-gnu'

nightly-x86_64-unknown-linux-gnu unchanged - rustc 1.61.0-nightly (9c06e1ba4 2022-03-29)

$ rustc -V
rustc 1.61.0-nightly (9c06e1ba4 2022-03-29)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants