Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add String::from_utf16. #306

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Add String::from_utf16. #306

merged 4 commits into from
Dec 14, 2023

Conversation

reitermarkus
Copy link
Member

Add equivalent to std::string::String::from_utf16 and additional push_utf16 helper method.

burrbull
burrbull reviewed Aug 3, 2022
View reviewed changes
src/lib.rs Show resolved Hide resolved
japaric
japaric suggested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'd like to keep push_utf16 private for now but otherwise this looks good. could you please address my inline comments and update the changelog?

src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
japaric
japaric reviewed Sep 23, 2022
View reviewed changes
src/string.rs Outdated Show resolved Hide resolved
@reitermarkus reitermarkus requested a review from japaric October 7, 2022 20:21
@reitermarkus reitermarkus force-pushed the string-utf16 branch 6 times, most recently from 9811da6 to ce7bf45 Compare November 22, 2023 14:14
@reitermarkus
Copy link
Member Author

@japaric, I have removed the push_utf16 method now.

@reitermarkus reitermarkus changed the title Add String::from_utf16 and String::push_utf16. Add String::from_utf16. Nov 22, 2023
newAM
newAM requested changes Dec 14, 2023
View reviewed changes
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the feature & documentation update! Just one small change that I think it worth making.

src/string.rs Outdated Show resolved Hide resolved
Dirbaio
Dirbaio reviewed Dec 14, 2023
View reviewed changes
src/indexmap.rs Outdated Show resolved Hide resolved
Dirbaio
Dirbaio reviewed Dec 14, 2023
View reviewed changes
src/lib.rs Show resolved Hide resolved
@reitermarkus reitermarkus force-pushed the string-utf16 branch 2 times, most recently from f571c2e to 01c1cf4 Compare December 14, 2023 22:15
@newAM newAM enabled auto-merge December 14, 2023 22:54
@newAM newAM added this pull request to the merge queue Dec 14, 2023
Merged via the queue into rust-embedded:main with commit fc099ec Dec 14, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dirbaio Dirbaio Dirbaio left review comments

@newAM newAM newAM approved these changes

@japaric japaric Awaiting requested review from japaric

@burrbull burrbull Awaiting requested review from burrbull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reitermarkus @Dirbaio @burrbull @japaric @newAM