Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an async implementation of Queue #324

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,11 @@ optional = true
[dev-dependencies.ufmt]
version = "0.1"

[dev-dependencies.tokio]
version = "1"
default-features = false
features = [ "macros", "rt", "time" ]

[dependencies.defmt]
version = ">=0.2.0,<0.4"
optional = true
Expand Down
7 changes: 7 additions & 0 deletions src/async_impl/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
//! This module contains an async variant of [`Queue`]
//!
//! [`Queue`]: crate::spsc::Queue

mod ssq;

pub mod spsc;
131 changes: 131 additions & 0 deletions src/async_impl/spsc/consumer.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,131 @@
use core::{
future::Future,
task::{Poll, Waker},
};

use crate::{
async_impl::ssq::{WakerConsumer, WakerProducer},
spsc::Consumer as HConsumer,
};

/// An async consumer
pub struct Consumer<'queue, T, const N: usize>
where
T: Unpin,
{
inner: HConsumer<'queue, T, N>,
producer_waker: WakerConsumer<'queue>,
consumer_waker: WakerProducer<'queue>,
}

impl<'queue, T, const N: usize> Consumer<'queue, T, N>
where
T: Unpin,
{
pub(crate) fn new(
consumer: HConsumer<'queue, T, N>,
producer_waker: WakerConsumer<'queue>,
consumer_waker: WakerProducer<'queue>,
) -> Self {
Self {
inner: consumer,
producer_waker,
consumer_waker,
}
}

/// Check if there are any items to dequeue.
///
/// When this returns true, at least the first subsequent [`Self::dequeue`] will succeed immediately
pub fn ready(&self) -> bool {
self.inner.ready()
}

/// Returns the maximum number of elements the queue can hold
pub fn capacity(&self) -> usize {
self.inner.capacity()
}

/// Returns the amount of elements currently in the queue
pub fn len(&self) -> usize {
self.inner.len()
}

/// Dequeue an item from the backing queue.
///
/// The returned future only resolves once an item was succesfully
/// dequeued.
pub fn dequeue<'me>(&'me mut self) -> ConsumerFuture<'me, 'queue, T, N> {
ConsumerFuture {
consumer: self,
dequeued_value: None,
}
}

/// Attempt to dequeue an item from the backing queue.
pub fn try_dequeue(&mut self) -> Option<T> {
self.try_wake_producer();

self.inner.dequeue()
}

/// Try to wake the [`Producer`](super::Producer) associated with the backing queue if
/// it is waiting to be awoken.
fn try_wake_producer(&mut self) {
self.producer_waker.dequeue().map(|w| w.wake());
}

/// Register `waker` as the waker for this [`Consumer`]
fn register_waker<'v>(&mut self, waker: Waker) -> bool {
self.consumer_waker.enqueue(waker).is_none()
}
}

pub struct ConsumerFuture<'consumer, 'queue, T, const N: usize>
where
T: Unpin,
{
consumer: &'consumer mut Consumer<'queue, T, N>,
dequeued_value: Option<T>,
}

impl<T, const N: usize> Future for ConsumerFuture<'_, '_, T, N>
where
T: Unpin,
{
type Output = T;

fn poll(
self: core::pin::Pin<&mut Self>,
cx: &mut core::task::Context<'_>,
) -> Poll<Self::Output> {
let try_wake_producer = |me: &mut Self, value| {
me.consumer.try_wake_producer();
return Poll::Ready(value);
};

let me = self.get_mut();
let con = &mut me.consumer;

if let Some(value) = me.dequeued_value.take() {
// Try to wake the producer because we managed to
// dequeue a value
return try_wake_producer(me, value);
}

me.dequeued_value = con.inner.dequeue();
if let Some(value) = me.dequeued_value.take() {
// Try to wake the producer because we managed to
// dequeue a value
try_wake_producer(me, value)
} else {
if !me.consumer.register_waker(cx.waker().clone()) {
// We failed to register the waker for some reason,
// wake immediately.
cx.waker().wake_by_ref();
}

Poll::Pending
}
}
}
97 changes: 97 additions & 0 deletions src/async_impl/spsc/mod.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
//! An async wrapper around [`Queue`]
use crate::spsc::Queue as HQueue;

mod producer;
pub use producer::Producer;

mod consumer;
pub use consumer::Consumer;

use super::ssq::WakerQueue;

/// An async queue
pub struct Queue<T, const N: usize>
where
T: Unpin,
{
inner: HQueue<T, N>,
producer_waker: WakerQueue,
consumer_waker: WakerQueue,
}

impl<T, const N: usize> Queue<T, N>
where
T: Unpin,
{
/// Create a new Queue
pub const fn new() -> Self {
Self {
inner: HQueue::new(),
producer_waker: WakerQueue::new(),
consumer_waker: WakerQueue::new(),
}
}

/// Split the queue into a producer and consumer
pub fn split(&mut self) -> (Producer<'_, T, N>, Consumer<'_, T, N>) {
let ((cwp, cwc), (pwp, pwc)) = (self.consumer_waker.split(), self.producer_waker.split());

let (producer, consumer) = self.inner.split();
(
Producer::new(producer, pwc, cwp),
Consumer::new(consumer, pwp, cwc),
)
}
}

#[cfg(test)]
mod test {
use std;
use std::boxed::Box;
use std::println;
use std::time::Duration;
use std::vec::Vec;

use super::Queue;

#[tokio::test]
async fn spsc() {
let queue: &'static mut Queue<u32, 8> = Box::leak(Box::new(Queue::new()));

let (mut tx, mut rx) = queue.split();
const MAX: u32 = 100;
let mut data = Vec::new();
for i in 0..=MAX {
data.push(i);
}

let t1_data = data.clone();
let t1 = tokio::task::spawn(async move {
println!("Dequeueing...");
let mut rx_data = Vec::new();
loop {
let value = rx.dequeue().await;
println!("Succesfully dequeued {}", value);
rx_data.push(value);
if value == MAX {
break;
}
}
assert_eq!(t1_data, rx_data);
});

let t2 = tokio::task::spawn(async move {
let mut interval = tokio::time::interval(Duration::from_millis(1));
println!("Enqueing...");
for i in data {
tx.enqueue(i).await;
interval.tick().await;
println!("Succesfully enqueued {}", i);
}
});

let (t1, t2) = tokio::join!(t1, t2);
t1.unwrap();
t2.unwrap();
}
}
136 changes: 136 additions & 0 deletions src/async_impl/spsc/producer.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,136 @@
use core::{
future::Future,
task::{Poll, Waker},
};

use crate::{
async_impl::ssq::{WakerConsumer, WakerProducer},
spsc::Producer as HProducer,
};

/// An async producer
pub struct Producer<'queue, T, const N: usize>
where
T: Unpin,
{
inner: HProducer<'queue, T, N>,
producer_waker: WakerProducer<'queue>,
consumer_waker: WakerConsumer<'queue>,
}

impl<'queue, T, const N: usize> Producer<'queue, T, N>
where
T: Unpin,
{
pub(crate) fn new(
producer: HProducer<'queue, T, N>,
producer_waker: WakerProducer<'queue>,
consumer_waker: WakerConsumer<'queue>,
) -> Self {
Self {
inner: producer,
producer_waker,
consumer_waker,
}
}

/// Check if an item can be enqueued.
///
/// If this returns true, at least the first subsequent [`Self::enqueue`] will succeed
/// immediately.
pub fn ready(&self) -> bool {
self.inner.ready()
}

/// Returns the maximum number of elements the queue can hold.
pub fn capacity(&self) -> usize {
self.inner.capacity()
}

/// Returns the amount of elements currently in the queue.
pub fn len(&self) -> usize {
self.inner.len()
}

/// Enqueue `value` into the backing queue.
///
/// The returned Future only resolves once the value was
/// succesfully enqueued.
pub fn enqueue<'me>(&'me mut self, value: T) -> ProducerFuture<'me, 'queue, T, N> {
let value = self.inner.enqueue(value).err();
ProducerFuture {
producer: self,
value_to_enqueue: value,
}
}

/// Try to enqueue `value` into the backing queue.
pub fn try_enqueue(&mut self, value: T) -> Result<(), T> {
self.inner.enqueue(value)
}

/// Try to wake the [`Consumer`](super::Consumer) associated with the backing queue if
/// it is waiting to be awoken.
fn wake_consumer(&mut self) {
self.consumer_waker.dequeue().map(|v| v.wake());
}

/// Register `waker` as the waker for this [`Producer`]
fn register_waker<'v>(&mut self, waker: Waker) -> bool {
// We can safely overwrite the old waker, as we can only ever have 1 instance
// of `self` waiting to be awoken.
self.producer_waker.enqueue(waker).is_none()
}
}

pub struct ProducerFuture<'producer, 'queue, T, const N: usize>
where
T: Unpin,
{
producer: &'producer mut Producer<'queue, T, N>,
value_to_enqueue: Option<T>,
}

impl<T, const N: usize> Future for ProducerFuture<'_, '_, T, N>
where
T: Unpin,
{
type Output = ();

fn poll(
self: core::pin::Pin<&mut Self>,
cx: &mut core::task::Context<'_>,
) -> Poll<Self::Output> {
let try_wake_consumer = |me: &mut Self| {
me.producer.wake_consumer();
Poll::Ready(())
};

let me = self.get_mut();
let prod = &mut me.producer;
let val_to_enqueue = &mut me.value_to_enqueue;

let value = if let Some(value) = val_to_enqueue.take() {
value
} else {
// Try to wake the consumer because we've enqueued our value
return try_wake_consumer(me);
};

let failed_enqueue_value = if let Some(value) = prod.inner.enqueue(value).err() {
value
} else {
// Try to wake the consumer because we've enqueued our value
return try_wake_consumer(me);
};

me.value_to_enqueue = Some(failed_enqueue_value);

if !me.producer.register_waker(cx.waker().clone()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should replace the previous waker instead of spinning the CPU at 100%.

Also, cloning wakers is moderately expensive in many executors (it does atomic refcount ops. Not in embassy or RTIC though), so it's nice to avoid cloning if possible. The way you do it is:

  • If no waker registered, clone and register it.
  • If a waker is registered:
    • If old_waker.will_wake(new_waker) do nothing. This saves a clone.
    • Otherwise, drop the old one, clone the new one and register it.

// We failed to enqueue the waker for some reason,
// re-wake immediately.
cx.waker().wake_by_ref();
}
Poll::Pending
}
}
Loading