asm: set unsafety of nop and delay functions to safe
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and a small codestyle fix in Cargo.toml file. Signed-off-by: Zhouqi Jiang <[email protected]>
luojia65
force-pushed
the
luojia65/asm-fixes
branch
from
6b60b3b
to
f422a25
Compare
romancardenas
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NOP instruction does not change architecturally visible state, including operations that would break memory safety boundaries; thus
nopinstruction wrapper should be safe to call. Thedelayfunction uses ADDI and BNE instructions which would form a function internal loop, which is safe under Rust constraints.This pull request also includes an explanation on NOP instruction under Rust docs, and a small codestyle fix in Cargo.toml file.
I modified internal macro
instructionto allow wrapping instruction with safe functions. If it's inappropriate, please reply and I'll change to other ways of implementation.