Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv-rt: Rework on exception and interrupt handling #161

Merged
merged 2 commits into from
Dec 13, 2023
Merged

riscv-rt: Rework on exception and interrupt handling #161

merged 2 commits into from
Dec 13, 2023

Conversation

romancardenas
Copy link
Contributor

This PR consists of three major contributions:

  • Removed U-mode interrupts, as they are no longer in the standard
  • Transition from Vector unions to Option<fn>. Both are equivalent, as Option<fn> exploits a niche optimization that uses 0usize to represent None. However, using Options is more idiomatic than Unions
  • Added a mechanism to deal with exceptions that is similar to how we treat interrupts. Now, it allow us to define custom exception handlers for standard exception sources.

@romancardenas romancardenas requested a review from a team as a code owner December 4, 2023 16:57
almindor
almindor approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@almindor almindor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romancardenas romancardenas added this pull request to the merge queue Dec 13, 2023
Merged via the queue into master with commit 5c447b8 Dec 13, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almindor almindor almindor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romancardenas @almindor