Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid spurious errors from LLVM #176

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Avoid spurious errors from LLVM #176

merged 2 commits into from
Jan 23, 2024

Conversation

romancardenas
Copy link
Contributor

Motivated by #175 , I added a provisional patch to prevent LLVM from logging spurious errors when compiling for targets with certain extensions (e.g., M or G) in release mode. The patch already contains documentation and pointers to related issues.

@romancardenas romancardenas requested a review from a team as a code owner January 23, 2024 23:05
MabezDev
MabezDev previously approved these changes Jan 23, 2024
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@romancardenas
Copy link
Contributor Author

@MabezDev I had a silly issue with riscv32i targets. Could you take a second look?

@MabezDev MabezDev added this pull request to the merge queue Jan 23, 2024
Merged via the queue into master with commit 59cbc52 Jan 23, 2024
77 checks passed
@romancardenas romancardenas deleted the llvm-error branch January 24, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants