-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mstatus helpers to allow setting fields in Mstatus #207
Merged
Merged
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2f9b748
Add Mstatus helpers to allow setting fields in Mstatus
jsgf eaac5cd
mstatus: use `update_` for names
jsgf b061e7e
Add `write_csr_as` macro
jsgf 47ca030
Make mstatus::write(Mstatus) available
jsgf c05838a
Add some minimal tests
jsgf 8de908c
Change back to set_ to match cortex and tweak docs a bit
jsgf f968990
Add bitfield helpers and use them in mstatus
jsgf a2a9888
Make set_* take &mut self
jsgf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
/// Insert a new value into a bitfield | ||
/// | ||
/// `value` is masked to `width` bits and inserted into `orig`.` | ||
#[inline] | ||
pub fn bf_insert(orig: usize, bit: usize, width: usize, value: usize) -> usize { | ||
let mask = (1 << width) - 1; | ||
orig & !(mask << bit) | ((value & mask) << bit) | ||
} | ||
|
||
/// Extract a value from a bitfield | ||
/// | ||
/// Extracts `width` bits from bit offset `bit` and returns it shifted to bit 0.s | ||
#[inline] | ||
pub fn bf_extract(orig: usize, bit: usize, width: usize) -> usize { | ||
let mask = (1 << width) - 1; | ||
(orig >> bit) & mask | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can leave it as this, but now I don't find any reason why we should hide it from dependents. Maybe PACs find them handy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd hold off on that until we're confident it's a stable public api.