Tidy per-ext check-cfg flags #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a subset of #205, aside from (I think) handling the |
romancardenas
requested changes
May 7, 2024
| println!("cargo:rustc-check-cfg=cfg(riscv)"); | ||
| println!("cargo:rustc-check-cfg=cfg(riscv32)"); | ||
| println!("cargo:rustc-check-cfg=cfg(riscv64)"); | ||
| for ext in ['i', 'e', 'm', 'a', 'f', 'd', 'g', 'c'] { |
There was a problem hiding this comment.
I like this approach. Could you open a new PR with this modification, please? I think the rest of the crates are already fixed.
There was a problem hiding this comment.
Oh I just recycled this PR.
jsgf
changed the title
|
Ok rebased and just reduced to using a loop for per-ext checks. |
Merged
via the queue into
rust-embedded:master
with commit May 7, 2024
ad8a0bb
96 of 97 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emit
cargo::rustc-check-cfg=CHECK_CFGin build.rs so that they can be cross-checked even if cfg option itself isn't set.