Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv-rt-macros: update syn to v2.0 #221

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

agarof
Copy link
Contributor

@agarof agarof commented Jun 23, 2024

Upgrade syn in order to deduplicate dependencies in projects depending on riscv-rt, as most other crates have upgraded to version 2.
Tested by building and flashing a simple hello world to the ESP32-C3, with no difference between the two versions.

While syn's README states Version requirement: Syn supports rustc 1.61 and up., riscv-rt-macros still builds with 1.59.

@agarof agarof requested a review from a team as a code owner June 23, 2024 21:20
@romancardenas
Copy link
Contributor

romancardenas commented Jun 25, 2024

Thanks for the PR! It looks like we need to bump the MSRV to 1.61
@agarof please also remember to update the CI workflow so it passes

@agarof
Copy link
Contributor Author

agarof commented Jun 25, 2024

I bumped the MSRV of riscv-rt to 1.61, CI should pass now

@almindor
Copy link
Contributor

Thank you!

@almindor
Copy link
Contributor

I think this might be good as is nevertheless we should also bump the CI rust versions at https://github.com/rust-embedded/riscv/blob/master/.github/workflows/riscv-rt.yaml#L13-L14

@agarof
Copy link
Contributor Author

agarof commented Jun 27, 2024

@romancardenas romancardenas added this pull request to the merge queue Jun 27, 2024
Merged via the queue into rust-embedded:master with commit 9d3fb05 Jun 27, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants