Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: re-use mcountinhibit try_* functions #231

Merged

Conversation

rmsyn
Copy link
Contributor

@rmsyn rmsyn commented Oct 20, 2024

Re-uses the try_* functions in their panicking equivalents for a slight code-size reduction.

@rmsyn rmsyn requested a review from a team as a code owner October 20, 2024 23:01
@rmsyn rmsyn force-pushed the riscv/cleanup-mcountinhibit branch 2 times, most recently from 2fa610d to cda9177 Compare October 20, 2024 23:32
romancardenas
romancardenas previously approved these changes Oct 21, 2024
Copy link
Contributor

@romancardenas romancardenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessebraham
jessebraham previously approved these changes Oct 21, 2024
Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@romancardenas
Copy link
Contributor

@rmsyn please fix conflicts so we can merge it

Re-uses the `try_*` functions in their panicking equivalents for a
slight code-size reduction.
@rmsyn rmsyn dismissed stale reviews from jessebraham and romancardenas via bf766e1 October 24, 2024 23:40
@rmsyn rmsyn force-pushed the riscv/cleanup-mcountinhibit branch from cda9177 to bf766e1 Compare October 24, 2024 23:40
@romancardenas romancardenas added this pull request to the merge queue Oct 25, 2024
Merged via the queue into rust-embedded:master with commit 64957b3 Oct 25, 2024
101 checks passed
@rmsyn rmsyn deleted the riscv/cleanup-mcountinhibit branch October 26, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants