-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv: use CSR macros for mcounteren #234
Merged
romancardenas
merged 6 commits into
rust-embedded:master
from
rmsyn:riscv/mcounteren-csr-macro
Nov 4, 2024
Merged
riscv: use CSR macros for mcounteren #234
romancardenas
merged 6 commits into
rust-embedded:master
from
rmsyn:riscv/mcounteren-csr-macro
Nov 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romancardenas
previously approved these changes
Oct 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uses CSR helper macros to define the `mcounteren` register.
Uses the CSR test helper macro for `mcounteren` register bit fields.
Extends the CSR test helper macro to handle range bit fields.
Uses the CSR test helper macro for `mcounteren` range fields.
Adds a CSR test helper macro branch for invalid range field values.
Uses the CSR test helper macro for invalid `mcounteren` range field values.
rmsyn
force-pushed
the
riscv/mcounteren-csr-macro
branch
from
November 2, 2024 01:18
e4d24ba
to
783906a
Compare
I added some extensions to the CSR test helper macro, and applied them to the unit tests for Let me know what you think. |
romancardenas
approved these changes
Nov 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses CSR helper macros to define the
mcounteren
register.Related: #229