Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded-hal dependency to 1.0.0-alpha.7 #96

Conversation

ahmedcharles
Copy link

No description provided.

@ahmedcharles ahmedcharles requested a review from a team as a code owner February 23, 2022 05:44
@Disasm
Copy link
Member

Disasm commented Feb 23, 2022

Thank you for the PR! Could you explain how these alpha-updates should work? Do we need to release an alpha version of the riscv crate with this change? In any case, I don't think it's a good idea to merge it directly to master as this would create problems for regular releases.

@ahmedcharles
Copy link
Author

My current goal is to update various dependencies across all the crates locally so I can at least try to test them. The PRs are mostly to avoid duplicate effort.

Once I can flash something to my hifive revb, I'll make more concrete suggestions for how to release.

Thanks for commenting.

@ahmedcharles ahmedcharles changed the base branch from master to staging February 24, 2022 20:50
@ahmedcharles
Copy link
Author

I updated the PR to update the version and switched to the staging branch. I think this would be the first crate that needs to be updated now that I have a test project compiling/working.

@Disasm
Copy link
Member

Disasm commented Mar 19, 2022

staging is a special branch used by bors for testing. I don't think it's a good idea to merge anything into it as it will be removed later.

@ahmedcharles
Copy link
Author

Ok, is there another branch I should merge it into for an alpha release?

@romancardenas
Copy link
Contributor

Closing, as this has been addressed in #147

romancardenas pushed a commit that referenced this pull request Nov 17, 2023
96: Add missing changelog entries r=almindor a=Disasm



Co-authored-by: Vadim Kaushan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants