Merge #176

176: check for wrong range size r=burrbull a=Emilgardis Co-authored-by: Emil Gardström <[email protected]>
rust-embedded · Nov 10, 2021 · 417539e · 417539e
2 parents a08622a + d880c4b
commit 417539e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/svd-parser/src/bitrange.rs b/svd-parser/src/bitrange.rs
@@ -7,6 +7,7 @@ pub enum InvalidBitRange {
     ParseError,
     MsbLsb,
     Empty,
+    Size,
 }
 
 impl Parse for BitRange {
@@ -83,6 +84,9 @@ impl Parse for BitRange {
                 return Err(SVDError::InvalidBitRange(InvalidBitRange::Syntax).at(tree.id()));
             };
 
+        if start > end {
+            return Err(SVDError::InvalidBitRange(InvalidBitRange::Size).at(tree.id()));
+        }
         Ok(Self {
             offset: start,
             width: end - start + 1,

diff --git a/svd-rs/CHANGELOG.md b/svd-rs/CHANGELOG.md
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## Unreleased
 
+- Add check for wrong size of `bitRange` width
 - Don't clone when serialize
 - Add optional entries to `Cpu`
 - `AddressBlock` & `Interrupt` now use builders