-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling #18
Comments
I have a WIP branch that does this. It is not exactly what I would like it to be currently, but it gives me a much better picture of what happened on an error. |
I'm going to wait for rust-embedded/svd2rust#53 and then rebase my branch. I have also implemented #21 on that branch, it should be on a separate pr. |
Hello, Whats the state of this issue? I am trying to generate a PAC for the VA108xx device by using their svd files and I think something like a line number for this error [ERROR svd2rust] expected `,` would help |
This has been done, but it could be improved upon, I dont think we can capture line numbers currently, but I will check. I'll return to you in your other comment on issue #41 |
I have dug a little bit deeper and I can confirm that the error comes from the |
See related issue rust-embedded/svd2rust#51
svd-parser
usesOption<String>
forElementExt::get_child_text
, and an expect is done with the definedtry!
macro in lib.rs, avoiding any way of knowing what had gone wrong. I propose forsvd-parser
to useerror-chain
to fix this problem, but also to use a logging crate to make debugging svd errors easier for the user without having to use utilities likeSVDConv.exe
to check for errors in the svd file and to see if the error is by missing implementation insvd2rust
.The text was updated successfully, but these errors were encountered: