Implement error handling #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bad_svd test is currently used to see how errors are made.
Also removed tests unrelated to svdparser
This has changed how parsing is done. All parsing is done in that "modules" _parse function and mapping of errors are done in parse. This allows us to wrap every possible source of failure and apply a context to it. Also fixed `RegisterClusterArrayInfo::dim_index` where `and_then_result` could have been used
Also updgraded failure to 0.1.1
There is a problem somewhere, as the PeripheralError in `register_name_missing` doesn't seem to have a cause. Also, we have to match differently when we are nested deeper with a named peripheral. May have to ultimately just have one error for named and unnamed peripherals/register/etc and implement the display differently depending on name: Option<String>
|
I'm not 💯 on implementing errors yet, but would the solution to match be to expose an |
|
This may all be due to bad usage of I am currently looking into implementing |
|
Work is being reimplemented in the refactor branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds error handling via
failure. This implementation does however need some work on it as the generated errors doesn't seem matchable in it's current state.TODO
fn(...) -> Result<_,Error>intofn(...) -> Result<_,FnSpecificError>This should fix item 2, but I'm not sure.
Part of #46 and #18