Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add write constraint range check #233

Merged

Conversation

kossnikita
Copy link
Contributor

fixes #232

@kossnikita kossnikita requested a review from a team as a code owner October 3, 2023 09:06
burrbull
burrbull previously approved these changes Oct 3, 2023
@burrbull
Copy link
Member

burrbull commented Oct 3, 2023

rustfmt, please

burrbull
burrbull previously approved these changes Oct 3, 2023
@burrbull
Copy link
Member

burrbull commented Oct 3, 2023

Possibly check also self.min<=self.max?

@kossnikita
Copy link
Contributor Author

kossnikita commented Oct 3, 2023

self.min<=self.max?

I'm not sure they can't be equal.

It is possible to limit the range of values to just one.

UPD: Sorry, that's what you meant.

@kossnikita kossnikita force-pushed the feature/write-constraint-check branch from 3b9335b to 822a680 Compare October 3, 2023 14:03
@burrbull burrbull added this pull request to the merge queue Oct 3, 2023
Merged via the queue into rust-embedded:master with commit 9bc8f31 Oct 3, 2023
7 checks passed
@kossnikita kossnikita deleted the feature/write-constraint-check branch October 5, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check writeConstraint range
2 participants