Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common 0.18 #508

Closed
wants to merge 3 commits into from
Closed

Common 0.18 #508

wants to merge 3 commits into from

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Apr 17, 2021

I've merged all PRs I want to see in 0.18. (#509, #506, #429, #503 and #499)
They all are not breaking.

@burrbull burrbull requested a review from a team as a code owner April 17, 2021 04:55
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Apr 17, 2021
@adamgreig
Copy link
Member

Let's merge them individually, it's easier to review. Is there anything else besides the open PRs that you would like for 0.18?

@burrbull
Copy link
Member Author

Let's merge them individually, it's easier to review. Is there anything else besides the open PRs that you would like for 0.18?

I have yet one idea, but it is not important and can wait. So that's enough.
Please, rerun bors in #503

@burrbull burrbull closed this Apr 17, 2021
bors bot added a commit to stm32-rs/stm32-rs that referenced this pull request Jul 22, 2021
540: updates for working with next svd2rust release r=adamgreig a=burrbull

rust-embedded/svd2rust#508

Co-authored-by: Andrey Zgarbul <[email protected]>
@burrbull burrbull deleted the common0.18 branch October 3, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants