Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run ci on merging instead of push #727

Merged
merged 2 commits into from
Jun 4, 2023
Merged

run ci on merging instead of push #727

merged 2 commits into from
Jun 4, 2023

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jun 4, 2023 •
edited by Emilgardis
Loading

resolves #724

@burrbull burrbull requested a review from a team as a code owner June 4, 2023 17:21
@burrbull burrbull added the no changelog no-changelog label Jun 4, 2023
Emilgardis
Emilgardis previously requested changes Jun 4, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Emilgardis Emilgardis mentioned this pull request Jun 4, 2023
Merged
@Emilgardis
Copy link
Member

Need to delete bors.toml also

I've corrected the settings to use the CI checks also

image

@Emilgardis
Copy link
Member

oh and merge_group on rustfmt 👍🏼

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

Need to delete bors.toml also

Done

@Emilgardis
Copy link
Member

Emilgardis commented Jun 4, 2023 •
edited
Loading

need to add merge_group to the rustfmt check also

I did a similar thing in #726 here and replaced check with clippy, I think you might've missed that considering the discussion in rust-embedded/svd#225

@burrbull
Copy link
Member Author

burrbull commented Jun 4, 2023

need to add merge_group to the rustfmt check also

Rustfmt is in same file as CI

@Emilgardis
Copy link
Member

haha, confusing with multiple different setups :)

Emilgardis
Emilgardis approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

f bors, thank you for your service 🫡

@Emilgardis Emilgardis enabled auto-merge June 4, 2023 18:30
@Emilgardis Emilgardis added this pull request to the merge queue Jun 4, 2023
Merged via the queue into master with commit f97e2da Jun 4, 2023
@Emilgardis Emilgardis deleted the ci branch June 4, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees
No one assigned
Labels
no changelog no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update CI
2 participants
@burrbull @Emilgardis