No longer set DEVICE_PERIPHERALS in steal() #735
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've discussed this a bit in the weekly meetings, I propose removing setting
DEVICE_PERIPHERALS
fromsteal()
and leave it only intake()
. This shouldn't meaningfully change the safety conditions or the use of either API, but does make stealing zero-cost. It was always possible to unsafelytransmute()
to obtainPeripherals
without settingDEVICE_PERIPHERALS
, so I'm interested if anyone can remember why this existed in the first place or if it is indeed still needed.