Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array-proxy for disjoint arrays #749

Merged
merged 1 commit into from
Oct 22, 2023
Merged

array-proxy for disjoint arrays #749

merged 1 commit into from
Oct 22, 2023

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Oct 14, 2023

fixes #748
cc @kossnikita

@kossnikita
Copy link

Did I miss something?

error[E0277]: `generic::ArrayProxy<generic::Reg<tmr1::cdt::CDT_SPEC>, 4, 4>` doesn't implement `Debug`
  --> src\tmr1.rs:34:5
   |
3  | #[derive(Debug)]
   |          ----- in this derive macro expansion
...
34 |     pub cdt: crate::ArrayProxy<CDT, 4, 0x04>,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `generic::ArrayProxy<generic::Reg<tmr1::cdt::CDT_SPEC>, 4, 4>` cannot be formatted using `{:?}`

@burrbull
Copy link
Member Author

Try again.

@burrbull
Copy link
Member Author

@n8tlarsen Could you test if nothing broken?

@kossnikita
Copy link

Works good in my case

@burrbull burrbull marked this pull request as ready for review October 14, 2023 10:07
@burrbull burrbull requested a review from a team as a code owner October 14, 2023 10:07
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@burrbull burrbull added this pull request to the merge queue Oct 22, 2023
Merged via the queue into master with commit 52a9b48 Oct 22, 2023
43 checks passed
@burrbull burrbull deleted the array-proxy branch October 22, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement disjoint array
3 participants