Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shorter names for constants #752

Closed
wants to merge 1 commit into from
Closed

shorter names for constants #752

wants to merge 1 commit into from

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Oct 20, 2023 •
edited
Loading

Due to less lines in write and modify this potentially leads to smaller size of debug builds.

cc @kossnikita Test this also, please.

@burrbull burrbull requested a review from a team as a code owner October 20, 2023 07:04
@kossnikita
Copy link

kossnikita commented Oct 20, 2023 •
edited
Loading

Tested with #751 and #751 + #752

                   before PR vs after PR
qei               30268/9504 vs 30268/9504
pwm               35612/9524 vs 35612/9524

UPD: No difference

@burrbull
Copy link
Member Author

cc @rust-embedded/tools

@burrbull burrbull marked this pull request as draft October 20, 2023 08:12
@burrbull burrbull changed the title shorten names for constants shorter names for constants Oct 20, 2023
Emilgardis
Emilgardis requested changes Oct 22, 2023
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not in favor of this change, makes it more obfuscated imo

since it's const and not static there shouldn't be any difference

@burrbull burrbull closed this Oct 22, 2023
@burrbull burrbull deleted the tst branch November 21, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @kossnikita @Emilgardis