fix and check compilation with no features #876

Emilgardis · 2024-10-23T15:56:21Z

resolves #875

jannic · 2024-10-23T16:11:27Z

src/config.rs

@@ -37,6 +37,7 @@ pub struct Config {
    pub base_address_shift: u64,
    pub html_url: Option<url::Url>,
    /// Path to YAML file with chip-specific settings
+    #[cfg(feature = "yaml")]
    pub settings: Option<PathBuf>,


I think this would just ignore the settings file, even if it is configured, correct?
Wouldn't it be better to report an error instead, like I implemented in #877?

jannic · 2024-10-23T16:20:09Z

.github/workflows/ci.yml

@@ -42,6 +42,9 @@ jobs:
        with:
          key: ${{ matrix.TARGET }}

+      - run: cargo check --target ${{ matrix.TARGET }} --no-default-features


Good idea, I copied this over to #877 (with you as the commit author), hope that's ok,

fix and check compilation with no features

6728118

Emilgardis requested a review from a team as a code owner October 23, 2024 15:56

jannic reviewed Oct 23, 2024

View reviewed changes

Emilgardis closed this Oct 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix and check compilation with no features #876

fix and check compilation with no features #876

Emilgardis commented Oct 23, 2024

jannic Oct 23, 2024

jannic Oct 23, 2024

fix and check compilation with no features #876

fix and check compilation with no features #876

Conversation

Emilgardis commented Oct 23, 2024

jannic Oct 23, 2024

Choose a reason for hiding this comment

jannic Oct 23, 2024

Choose a reason for hiding this comment