Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not implement InterruptNumber for XtensaLx #883

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Nov 5, 2024

InterruptNumber is not useful for us because it's meant to provide an interface for CPU interrupts, but it's implemented by svd2rust for peripheral interrupts.

@bugadani bugadani requested a review from a team as a code owner November 5, 2024 13:31
Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@burrbull
Copy link
Member

burrbull commented Nov 5, 2024

@bugadani @MabezDev could somebody update CI?

Espressif)

@bugadani
Copy link
Contributor Author

bugadani commented Nov 5, 2024

What do you think needs updating there?

@burrbull
Copy link
Member

burrbull commented Nov 5, 2024

What do you think needs updating there?

Old crate versions?

@burrbull burrbull added this pull request to the merge queue Nov 5, 2024
Merged via the queue into rust-embedded:master with commit d56f939 Nov 5, 2024
46 checks passed
@bugadani bugadani deleted the xtensa-interrupt-number branch November 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants