Implement custom fold for ZipSlice #762
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #755 , this PR implements custom
fold
logic forZipSlices<T, U>
and create benchmark test to measure the performance gain compared with the defaultfold
.Running the
zipdot i32 zipslices fold
benchmark using the defaultfold
logic, the time wastime: [42.749 ns 43.163 ns 43.782 ns]
Running the
zipdot i32 zipslices fold
benchmark using the customfold
logic, the time wastime: [42.523 ns 42.621 ns 42.737 ns]