Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Debug for FormatWith, same as Display #931

Merged
merged 1 commit into from
May 7, 2024

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented May 4, 2024

Fixes #929

The type std::fmt::Arguments (returned by format_args!) similarly delegates Debug to Display.

The type `std::fmt::Arguments` (returned by `format_args!`) similarly delegates `Debug` to `Display`.
Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 94.50%. Comparing base (6814180) to head (0ea20f2).
Report is 64 commits behind head on master.

Files Patch % Lines
src/format.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #931      +/-   ##
==========================================
+ Coverage   94.38%   94.50%   +0.11%     
==========================================
  Files          48       48              
  Lines        6665     6893     +228     
==========================================
+ Hits         6291     6514     +223     
- Misses        374      379       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet added this pull request to the merge queue May 7, 2024
Merged via the queue into rust-itertools:master with commit 0fcc6d1 May 7, 2024
12 of 13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the issue-929 branch May 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatWith should implement fmt::Debug
2 participants