Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "cargo-semver-checks" action faster #938

Merged
merged 1 commit into from
May 16, 2024

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented May 15, 2024

"cargo-semver-checks-action" previously took 2mn30s in CI which sure is not that much but is still slower than all the rest. It was slowly (PR after PR) driving me nuts.
After installing cargo-semver-checks locally, I witnessed that run the binary was fast. I eventually looked at the CI log and I thought the installation of the toolchain could be the bottleneck.
For it (and other things), the semver-checks action uses "actions-rs/core" which has been recently archived and is therefore unmaintained and might be not as performant as alternatives.

So here, I install it with dtolnay/rust-toolchain@stable (same as other jobs) and set the toolchain to "manual" for "cargo-semver-checks-action". And now it's 🚀blazingly fast🔥!

tldr; CI is overall twice faster.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (6814180) to head (e3c849f).
Report is 90 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   94.38%   94.55%   +0.17%     
==========================================
  Files          48       49       +1     
  Lines        6665     7002     +337     
==========================================
+ Hits         6291     6621     +330     
- Misses        374      381       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Philippe-Cholet Philippe-Cholet marked this pull request as ready for review May 15, 2024 15:46
@Philippe-Cholet Philippe-Cholet modified the milestone: next May 16, 2024
@jswrenn jswrenn added this pull request to the merge queue May 16, 2024
Merged via the queue into rust-itertools:master with commit 4777762 May 16, 2024
13 checks passed
@Philippe-Cholet Philippe-Cholet deleted the slow-semver-check branch May 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants