Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Itertools::format[_with] docs mention panic within logging macro #941

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Itertools::format[_with] docs mention panic within logging macro #941

wants to merge 3 commits into from

Commits on Jun 18, 2024

  1. Itertools::format[_with] docs mention it can panic if used in loggi… 

    …ng macros

I failed to make the (invisible) macro usable as `tracing::info!` with some private module. Renamed it `tracing_info` instead.
I add `should_panic` but checked it panics for the right reason.
    @Philippe-Cholet
    Philippe-Cholet committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    c3f335b View commit details
    Browse the repository at this point in the history

  2. "Warning div" instead of emoji "⚠" 

    Markdown can not be used inside it.
It renders well in the documentation and in my IDE (Sublime Text: orange text).
    @Philippe-Cholet
    Philippe-Cholet committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    df96c73 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Merge branch 'master' into format-panic

    @phimuemue
    phimuemue authored Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b21f7aa View commit details
    Browse the repository at this point in the history