Auto merge of #14590 - epage:completest-bad, r=weihanglo

test: Remove completion tests

The tests are intended to spot check that shell completions are registered correctly.  That is a low change, low risk area.  For shell integration, we're relying on `clap_complete`s tests. For our own candidates, we should test the candidate generation directly, rather than end-to-end.

This reverts parts of commit e7ca9be, reversing changes made to bd5f32b.

Fixes #14545

.github/workflows/main.yml

@@ -173,13 +173,6 @@ jobs:
     - run: rustup target add ${{ matrix.other }}
     - run: rustup component add rustc-dev llvm-tools-preview rust-docs
       if: startsWith(matrix.rust, 'nightly')
-    # Install fish, zsh, and elvish only on Ubuntu systems
-    - name: Install fish, zsh, and elvish on Ubuntu
-      run: sudo apt update -y && sudo apt install fish zsh elvish -y
-      if: matrix.os == 'ubuntu-latest'
-    - name: Install fish, elvish on macOS
-      run: brew install fish elvish
-      if: matrix.os == 'macos-14' || matrix.os == 'macos-13'
     - run: sudo apt update -y && sudo apt install lldb gcc-multilib libsecret-1-0 libsecret-1-dev -y
       if: matrix.os == 'ubuntu-latest'
     - run: rustup component add rustfmt || echo "rustfmt not available"
@@ -234,7 +227,6 @@ jobs:
       - run: rustup update --no-self-update stable && rustup default stable
       - run: rustup target add i686-unknown-linux-gnu
       - run: sudo apt update -y && sudo apt install gcc-multilib libsecret-1-0 libsecret-1-dev -y
-      - run: sudo apt update -y && sudo apt install fish zsh elvish -y
       - run: rustup component add rustfmt || echo "rustfmt not available"
       - run: cargo test -p cargo
         env:

Cargo.toml

@@ -38,7 +38,6 @@ cargo_metadata = "0.18.1"
 clap = "4.5.18"
 clap_complete = { version = "4.5.29", features = ["unstable-dynamic"] }
 color-print = "0.3.6"
-completest-pty = "0.5.3"
 core-foundation = { version = "0.10.0", features = ["mac_os_10_7_support"] }
 crates-io = { version = "0.40.4", path = "crates/crates-io" }
 criterion = { version = "0.5.1", features = ["html_reports"] }
@@ -242,7 +241,6 @@ features = [
 [dev-dependencies]
 annotate-snippets = { workspace = true, features = ["testing-colors"] }
 cargo-test-support.workspace = true
-completest-pty.workspace = true
 gix = { workspace = true, features = ["revision"] }
 same-file.workspace = true
 snapbox.workspace = true

tests/testsuite/main.rs

@@ -166,7 +166,6 @@ mod rustflags;
 mod rustup;
 mod script;
 mod search;
-mod shell_completions;
 mod shell_quoting;
 mod source_replacement;
 mod ssh;