Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CC_ENABLE_DEBUG_OUTPUT if it is set to "0" #1234

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 6, 2024

It isn't always possible to completely unset an environment variable, but it is pretty common that a value of "0" should be treated as disabled. Use that here for CC_ENABLE_DEBUG_OUTPUT.

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just one minor nit.

src/command_helpers.rs Outdated Show resolved Hide resolved
It isn't always possible to completely unset an environment variable,
but it is pretty common that a value of "0" should be treated as
disabled. Use that here for `CC_ENABLE_DEBUG_OUTPUT`.
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I suppose we should do the same for other variables as well for consistency.

@NobodyXu NobodyXu merged commit 39c0aaf into rust-lang:main Oct 6, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Oct 6, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Oct 6, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants