fix unsoundness in mapped_futures cancel

rust-lang · Jul 18, 2024 · 7976819 · 7976819
1 parent 08acad3
commit 7976819
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/futures-util/src/stream/mapped_futures/mod.rs b/futures-util/src/stream/mapped_futures/mod.rs
@@ -166,7 +166,8 @@ impl<K: Hash + Eq, Fut> MappedFutures<K, Fut> {
         // if let Some(task) = self.hash_set.get(key) {
         if let Some(task) = self.set().take(key) {
             unsafe {
-                if let Some(_) = (*task.future.get()).take() {
+                if (*task.future.get()).is_some() {
+                    task.future.get().write(None);
                     self.inner.unlink(Arc::as_ptr(&task.inner));
                     return true;
                 }