Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add len method for UnboundedSender #2750

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

thement
Copy link
Contributor

@thement thement commented Jun 9, 2023

Add len method to inspect how many messages are enqueued in the message queue.

@taiki-e
Copy link
Member

taiki-e commented Jul 19, 2023

Thanks for the PR. Could you fix a clippy warning? (Other CI failures should be fixed by rebase)

@taiki-e taiki-e added the A-channel Area: futures::channel label Jul 19, 2023
@taiki-e
Copy link
Member

taiki-e commented Jul 19, 2023

Also, could you add a test for this?

@taiki-e taiki-e added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author label Jul 19, 2023
@thement thement force-pushed the master branch 2 times, most recently from 9994d24 to 969cef0 Compare July 25, 2023 12:23
- add `len`, `is_empty` methods to inspect how many messages are
  enqueued in the message queue.
- add test for `len` and `is_empty`
@thement
Copy link
Contributor Author

thement commented Jul 25, 2023

Fixed.

@taiki-e taiki-e added 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author labels Jul 25, 2023
@taiki-e taiki-e merged commit 0b2d34e into rust-lang:master Jul 25, 2023
24 checks passed
taiki-e pushed a commit that referenced this pull request Oct 26, 2023
- add `len`, `is_empty` methods to inspect how many messages are
  enqueued in the message queue.
- add test for `len` and `is_empty`

Co-authored-by: Jakub Horak <[email protected]>
@taiki-e taiki-e mentioned this pull request Oct 26, 2023
@taiki-e taiki-e added 0.3-backport: completed and removed 0.3-backport: pending The maintainer accepted to backport this to the 0.3 branch, but backport has not been done yet. labels Oct 26, 2023
taiki-e pushed a commit that referenced this pull request Oct 26, 2023
- add `len`, `is_empty` methods to inspect how many messages are
  enqueued in the message queue.
- add test for `len` and `is_empty`

Co-authored-by: Jakub Horak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants