Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove an outdated comment from docs #2774

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Remove an outdated comment from docs #2774

merged 1 commit into from
Sep 25, 2023

Conversation

WaffleLapkin
Copy link
Member

The comment in the example is wrong, since the example is actually wrapped in async{} (and this is used, note the .await at the end).

taiki-e
taiki-e approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e added the docs label Sep 25, 2023
@taiki-e taiki-e merged commit 2c1c3e1 into rust-lang:master Sep 25, 2023
25 checks passed
@WaffleLapkin WaffleLapkin deleted the remove_outdated_comment branch September 26, 2023 00:45
taiki-e pushed a commit that referenced this pull request Oct 26, 2023
@WaffleLapkin @taiki-e
Remove an outdated comment from docs (#2774)
7b68b15
@taiki-e taiki-e mentioned this pull request Oct 26, 2023
Merged
taiki-e pushed a commit that referenced this pull request Oct 26, 2023
@WaffleLapkin @taiki-e
Remove an outdated comment from docs (#2774)
78c7b79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
0.3-backport: completed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaffleLapkin @taiki-e