FillBuf: Do not call poll_fill_buf twice #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
A-io
|
poke :-) Can this be backported to 0.3 and a release tagged? 🙏 |
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
|
Published in 0.3.30. |
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Dec 24, 2023
The bugs have been fixed, rust-lang/futures-rs#2801 and rust-lang/futures-rs#2812 were merged and ended up in that release. Change-Id: Iefd990d2d1719b884504093343e54e9c5258e2e2 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10414 Reviewed-by: raitobezarius <[email protected]> Autosubmit: flokli <[email protected]> Tested-by: BuildkiteCI
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Dec 24, 2023
The bugs have been fixed, rust-lang/futures-rs#2801 and rust-lang/futures-rs#2812 were merged and ended up in that release. Change-Id: I301c0ffc951f04a5b3b7267e922771c837a3f5a9 Reviewed-on: https://cl.tvl.fyi/c/depot/+/10415 Autosubmit: flokli <[email protected]> Tested-by: BuildkiteCI Reviewed-by: raitobezarius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2801 (comment)