Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore newly added clippy lint #2823

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Ignore newly added clippy lint #2823

merged 1 commit into from
Jan 20, 2024

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 18, 2024

No description provided.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 18, 2024

Hmm... it seems that someone has changed the configuration of this repository.

gh

It is problematic to set up such ("one approval required") branch protection in a project where there is effectively only one maintainer, but they do not have the permissions to bypass the branch protection.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 18, 2024

Ok, I believe that is due to rust-lang/team#1187.

cc @Kobzol

I apologize for not being able to comment on that issue sooner, but I can't find an explanation about the possibility of such problems.
Could you tell me what needs to be done to fix this? Is it just a removal of the table regarding branch protection? Or can it be adjusted by adding a specific field?

@taiki-e
Copy link
Member Author

taiki-e commented Jan 18, 2024

Could you tell me what needs to be done to fix this? Is it just a removal of the table regarding branch protection? Or can it be adjusted by adding a specific field?

(It would be ideal if it would give me the (admin?) permission to bypass the protections when necessary...)

@Kobzol
Copy link

Kobzol commented Jan 18, 2024

Sorry for that, I missed that approvals weren't required before! rust-lang/team#1225 should fix it.

@taiki-e taiki-e closed this Jan 18, 2024
@taiki-e taiki-e reopened this Jan 18, 2024
@Kobzol
Copy link

Kobzol commented Jan 18, 2024

I'll investigate why it didn't work.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 20, 2024

The branch protection issue seems to be fixed now (by rust-lang/sync-team#62?). Thanks for fixing it @Kobzol.

@taiki-e taiki-e merged commit 0fa6a1a into master Jan 20, 2024
48 checks passed
@taiki-e taiki-e deleted the taiki-e/clippy branch January 20, 2024 02:12
@Kobzol
Copy link

Kobzol commented Jan 20, 2024

Sorry, I forgot to post here 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants