Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change condition for is_terminated in Zip #2895

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

haroldbruintjes
Copy link

The condition for is_terminated in the FusedStream impl for Zip should check if either child stream has terminated. Otherwise, one stream may be polled even after it has been terminated if the other has not.

This following example triggers the current bug:

use futures::stream::{self, StreamExt};

#[tokio::main]
pub async fn main() {
    let stream1 = stream::iter(vec![17, 19]);
    let stream2 = stream::iter(vec![17]);
    let mut zipped = stream1.zip(stream2);
    loop {
        futures::select!{
            res = zipped.select_next_some() => {
                println!("Zip result {res:?}");
            }
            complete => break,
        }
        
    }
}

The condition for `is_terminated` in the `FusedStream` impl for `Zip` should check if either child stream has terminated. Otherwise, one stream may be polled even after it has been terminated if the other has not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant