Skip to content

Commit

Permalink
Merge pull request #4231 from lvllvl/4117-part-3
Browse files Browse the repository at this point in the history 
Classify FIXMEs - 3
  • Loading branch information
@tgross35
tgross35 authored Feb 25, 2025
2 parents 989b64a + 861246a commit a92ecf7
Show file tree
Hide file tree
Showing 9 changed files with 53 additions and 53 deletions.
12 changes: 6 additions & 6 deletions src/unix/bsd/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ cfg_if! {
f.debug_struct("sockaddr_un")
.field("sun_len", &self.sun_len)
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(debug): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -232,11 +232,11 @@ cfg_if! {
impl fmt::Debug for utsname {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utsname")
// FIXME: .field("sysname", &self.sysname)
// FIXME: .field("nodename", &self.nodename)
// FIXME: .field("release", &self.release)
// FIXME: .field("version", &self.version)
// FIXME: .field("machine", &self.machine)
// FIXME(debug): .field("sysname", &self.sysname)
// FIXME(debug): .field("nodename", &self.nodename)
// FIXME(debug): .field("release", &self.release)
// FIXME(debug): .field("version", &self.version)
// FIXME(debug): .field("machine", &self.machine)
.finish()
}
}
Expand Down
20 changes: 10 additions & 10 deletions src/unix/bsd/netbsdlike/openbsd/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ cfg_if! {
.field("d_reclen", &self.d_reclen)
.field("d_type", &self.d_type)
.field("d_namlen", &self.d_namlen)
// FIXME: .field("d_name", &self.d_name)
// FIXME(debug): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -873,8 +873,8 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("lastlog")
.field("ll_time", &self.ll_time)
// FIXME: .field("ll_line", &self.ll_line)
// FIXME: .field("ll_host", &self.ll_host)
// FIXME(debug): .field("ll_line", &self.ll_line)
// FIXME(debug): .field("ll_host", &self.ll_host)
.finish()
}
}
Expand Down Expand Up @@ -913,9 +913,9 @@ cfg_if! {
impl fmt::Debug for utmp {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utmp")
// FIXME: .field("ut_line", &self.ut_line)
// FIXME: .field("ut_name", &self.ut_name)
// FIXME: .field("ut_host", &self.ut_host)
// FIXME(debug): .field("ut_line", &self.ut_line)
// FIXME(debug): .field("ut_name", &self.ut_name)
// FIXME(debug): .field("ut_host", &self.ut_host)
.field("ut_time", &self.ut_time)
.finish()
}
Expand Down Expand Up @@ -1048,10 +1048,10 @@ cfg_if! {
.field("f_namemax", &self.f_namemax)
.field("f_owner", &self.f_owner)
.field("f_ctime", &self.f_ctime)
// FIXME: .field("f_fstypename", &self.f_fstypename)
// FIXME: .field("f_mntonname", &self.f_mntonname)
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
// FIXME: .field("f_mntfromspec", &self.f_mntfromspec)
// FIXME(debug): .field("f_fstypename", &self.f_fstypename)
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
// FIXME(debug): .field("f_mntfromspec", &self.f_mntfromspec)
.field("mount_info", &self.mount_info)
.finish()
}
Expand Down
4 changes: 2 additions & 2 deletions src/unix/bsd/netbsdlike/openbsd/x86_64.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ cfg_if! {
.field("fx_rdp", &{ self.fx_rdp })
.field("fx_mxcsr", &{ self.fx_mxcsr })
.field("fx_mxcsr_mask", &{ self.fx_mxcsr_mask })
// FIXME: .field("fx_st", &{self.fx_st})
// FIXME: .field("fx_xmm", &{self.fx_xmm})
// FIXME(debug): .field("fx_st", &{self.fx_st})
// FIXME(debug): .field("fx_xmm", &{self.fx_xmm})
.finish()
}
}
Expand Down
10 changes: 5 additions & 5 deletions src/unix/haiku/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ cfg_if! {
f.debug_struct("sockaddr_un")
.field("sun_len", &self.sun_len)
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(debug): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -599,7 +599,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_pad2", &self.__ss_pad2)
// FIXME: .field("__ss_pad3", &self.__ss_pad3)
// FIXME(debug): .field("__ss_pad3", &self.__ss_pad3)
.finish()
}
}
Expand Down Expand Up @@ -636,7 +636,7 @@ cfg_if! {
.field("d_ino", &self.d_ino)
.field("d_pino", &self.d_pino)
.field("d_reclen", &self.d_reclen)
// FIXME: .field("d_name", &self.d_name)
// FIXME(debug): .field("d_name", &self.d_name)
.finish()
}
}
Expand Down Expand Up @@ -868,7 +868,7 @@ pub const LC_NUMERIC: c_int = 4;
pub const LC_TIME: c_int = 5;
pub const LC_MESSAGES: c_int = 6;

// FIXME: Haiku does not have MAP_FILE, but library/std/os.rs requires it
// FIXME(haiku): Haiku does not have MAP_FILE, but library/std/os.rs requires it
pub const MAP_FILE: c_int = 0x00;
pub const MAP_SHARED: c_int = 0x01;
pub const MAP_PRIVATE: c_int = 0x02;
Expand Down Expand Up @@ -1301,7 +1301,7 @@ pub const PTHREAD_MUTEX_NORMAL: c_int = 1;
pub const PTHREAD_MUTEX_ERRORCHECK: c_int = 2;
pub const PTHREAD_MUTEX_RECURSIVE: c_int = 3;

pub const FIOCLEX: c_ulong = 0; // FIXME: does not exist on Haiku!
pub const FIOCLEX: c_ulong = 0; // FIXME(haiku): does not exist on Haiku!

pub const RUSAGE_CHILDREN: c_int = -1;

Expand Down
10 changes: 5 additions & 5 deletions src/unix/haiku/x86_64.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,9 @@ cfg_if! {
.field("rdp", &self.rdp)
.field("mxcsr", &self.mxcsr)
.field("mscsr_mask", &self.mscsr_mask)
// FIXME: .field("_fpreg", &self._fpreg)
// FIXME: .field("_xmm", &self._xmm)
// FIXME: .field("_reserved_416_511", &self._reserved_416_511)
// FIXME(debug): .field("_fpreg", &self._fpreg)
// FIXME(debug): .field("_xmm", &self._xmm)
// FIXME(debug): .field("_reserved_416_511", &self._reserved_416_511)
.finish()
}
}
Expand Down Expand Up @@ -133,7 +133,7 @@ cfg_if! {
f.debug_struct("xstate_hdr")
.field("bv", &self.bv)
.field("xcomp_bv", &self.xcomp_bv)
// FIXME: .field("_reserved", &field._reserved)
// FIXME(debug): .field("_reserved", &field._reserved)
.finish()
}
}
Expand Down Expand Up @@ -162,7 +162,7 @@ cfg_if! {
f.debug_struct("savefpu")
.field("fp_fxsave", &self.fp_fxsave)
.field("fp_xstate", &self.fp_xstate)
// FIXME: .field("_fp_ymm", &field._fp_ymm)
// FIXME(debug): .field("_fp_ymm", &field._fp_ymm)
.finish()
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/unix/linux_like/linux/gnu/b64/x86_64/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ s_no_extra_traits! {
pub uc_mcontext: mcontext_t,
pub uc_sigmask: crate::sigset_t,
__private: [u8; 512],
// FIXME(linux): the shadow stack field requires glibc >= 2.28.
// FIXME(glibc): the shadow stack field requires glibc >= 2.28.
// Re-add once we drop compatibility with glibc versions older than
// 2.28.
//
Expand Down
2 changes: 1 addition & 1 deletion src/unix/linux_like/linux/musl/b32/hexagon.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ pub const SYS_clock_settime: c_int = 112;
pub const SYS_clone: c_int = 220;
pub const SYS_close: c_int = 57;
pub const SYS_connect: c_int = 203;
pub const SYS_copy_file_range: c_int = -1; // FIXME(musl)
pub const SYS_copy_file_range: c_int = -1; // FIXME(hexagon)
pub const SYS_creat: c_int = 1064;
pub const SYS_delete_module: c_int = 106;
pub const SYS_dup2: c_int = 1041;
Expand Down
14 changes: 7 additions & 7 deletions src/unix/nto/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -806,7 +806,7 @@ cfg_if! {
f.debug_struct("sockaddr_un")
.field("sun_len", &self.sun_len)
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(debug): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -1015,11 +1015,11 @@ cfg_if! {
impl fmt::Debug for utsname {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utsname")
// FIXME: .field("sysname", &self.sysname)
// FIXME: .field("nodename", &self.nodename)
// FIXME: .field("release", &self.release)
// FIXME: .field("version", &self.version)
// FIXME: .field("machine", &self.machine)
// FIXME(debug): .field("sysname", &self.sysname)
// FIXME(debug): .field("nodename", &self.nodename)
// FIXME(debug): .field("release", &self.release)
// FIXME(debug): .field("version", &self.version)
// FIXME(debug): .field("machine", &self.machine)
.finish()
}
}
Expand Down Expand Up @@ -1095,7 +1095,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
.finish()
}
}
Expand Down
32 changes: 16 additions & 16 deletions src/unix/solarish/mod.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ cfg_if! {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("sockaddr_un")
.field("sun_family", &self.sun_family)
// FIXME: .field("sun_path", &self.sun_path)
// FIXME(debug): .field("sun_path", &self.sun_path)
.finish()
}
}
Expand Down Expand Up @@ -632,11 +632,11 @@ cfg_if! {
impl fmt::Debug for utsname {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("utsname")
// FIXME: .field("sysname", &self.sysname)
// FIXME: .field("nodename", &self.nodename)
// FIXME: .field("release", &self.release)
// FIXME: .field("version", &self.version)
// FIXME: .field("machine", &self.machine)
// FIXME(debug): .field("sysname", &self.sysname)
// FIXME(debug): .field("nodename", &self.nodename)
// FIXME(debug): .field("release", &self.release)
// FIXME(debug): .field("version", &self.version)
// FIXME(debug): .field("machine", &self.machine)
.finish()
}
}
Expand All @@ -662,7 +662,7 @@ cfg_if! {
impl fmt::Debug for fd_set {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
f.debug_struct("fd_set")
// FIXME: .field("fds_bits", &self.fds_bits)
// FIXME(debug): .field("fds_bits", &self.fds_bits)
.finish()
}
}
Expand Down Expand Up @@ -691,7 +691,7 @@ cfg_if! {
.field("ss_family", &self.ss_family)
.field("__ss_pad1", &self.__ss_pad1)
.field("__ss_align", &self.__ss_align)
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
.finish()
}
}
Expand Down Expand Up @@ -740,7 +740,7 @@ cfg_if! {
&& self.si_code == other.si_code
&& self.si_errno == other.si_errno
{
// FIXME: The `si_pad` field in the 64-bit version of the struct is ignored
// FIXME(solarish): The `si_pad` field in the 64-bit version of the struct is ignored
// (for now) when doing comparisons.

let field_count = self.data_field_count();
Expand All @@ -760,7 +760,7 @@ cfg_if! {
.field("si_signo", &self.si_signo)
.field("si_code", &self.si_code)
.field("si_errno", &self.si_errno)
// FIXME: .field("__pad", &self.__pad)
// FIXME(debug): .field("__pad", &self.__pad)
.finish()
}
}
Expand All @@ -770,7 +770,7 @@ cfg_if! {
self.si_code.hash(state);
self.si_errno.hash(state);

// FIXME: The `si_pad` field in the 64-bit version of the struct is ignored
// FIXME(solarish): The `si_pad` field in the 64-bit version of the struct is ignored
// (for now) when doing hashing.

let field_count = self.data_field_count();
Expand Down Expand Up @@ -803,7 +803,7 @@ cfg_if! {
.field("sdl_nlen", &self.sdl_nlen)
.field("sdl_alen", &self.sdl_alen)
.field("sdl_slen", &self.sdl_slen)
// FIXME: .field("sdl_data", &self.sdl_data)
// FIXME(debug): .field("sdl_data", &self.sdl_data)
.finish()
}
}
Expand Down Expand Up @@ -853,7 +853,7 @@ cfg_if! {
impl PartialEq for pad128_t {
fn eq(&self, other: &pad128_t) -> bool {
unsafe {
// FIXME: self._q == other._q ||
// FIXME(solarish): self._q == other._q ||
self._l == other._l
}
}
Expand All @@ -862,15 +862,15 @@ cfg_if! {
impl hash::Hash for pad128_t {
fn hash<H: hash::Hasher>(&self, state: &mut H) {
unsafe {
// FIXME: state.write_i64(self._q as i64);
// FIXME(solarish): state.write_i64(self._q as i64);
self._l.hash(state);
}
}
}
impl PartialEq for upad128_t {
fn eq(&self, other: &upad128_t) -> bool {
unsafe {
// FIXME: self._q == other._q ||
// FIXME(solarish): self._q == other._q ||
self._l == other._l
}
}
Expand All @@ -879,7 +879,7 @@ cfg_if! {
impl hash::Hash for upad128_t {
fn hash<H: hash::Hasher>(&self, state: &mut H) {
unsafe {
// FIXME: state.write_i64(self._q as i64);
// FIXME(solarish): state.write_i64(self._q as i64);
self._l.hash(state);
}
}
Expand Down

0 comments on commit a92ecf7

Please sign in to comment.