Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more WASI libc bindings #1321

Closed
wants to merge 5 commits into from

Conversation

sunfishcode
Copy link
Member

I was writing some WASI code and needed some more bits from libc. Here's a patch adding more things from the intersection of things that WASI libc defines and things that other platforms in libc have bindings for.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Copy link
Contributor

@gnzlbg gnzlbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcrichton this LGTM, wasi is experimental so I don't see any issues with iterating on this in tree.

Some of the symbols are named __wasilibc, but others aren't. Is there a reason for this?

@sunfishcode
Copy link
Member Author

Some of the symbols are named __wasilibc, but others aren't. Is there a reason for this?

The __wasilibc_* functions are functions which are WASI-specific and not part of a typical libc API.

@alexcrichton
Copy link
Member

All looks good to me!

@sunfishcode looks like there's some verification errors on CI, and libc-test/build.rs may need to be updated for including more headers files or such on wasi.

While you're here, want to update the wasi check in src/lib.rs to any(target_env = "wasi", target_os = "wasi")?

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 19, 2019

📌 Commit 5fda33e has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 19, 2019

⌛ Testing commit 5fda33e with merge 19e81f3...

bors added a commit that referenced this pull request Apr 19, 2019
Add more WASI libc bindings

I was writing some WASI code and needed some more bits from libc. Here's a patch adding more things from the intersection of things that WASI libc defines and things that other platforms in libc have bindings for.
@sunfishcode
Copy link
Member Author

Investigating this more, this has turned up some bugs in on the wasi-sysroot side, so I'm going to step back here momentarily, fix those, and them come back to this.

bors added a commit that referenced this pull request Apr 23, 2019
Add more WASI libc bindings

This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
bors added a commit that referenced this pull request Apr 24, 2019
Add more WASI libc bindings

This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
bors added a commit that referenced this pull request Apr 25, 2019
Add more WASI libc bindings

This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants