-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more WASI libc bindings #1321
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexcrichton this LGTM, wasi is experimental so I don't see any issues with iterating on this in tree.
Some of the symbols are named __wasilibc
, but others aren't. Is there a reason for this?
The |
All looks good to me! @sunfishcode looks like there's some verification errors on CI, and While you're here, want to update the wasi check in |
Rustc is changing it to be target_os; for now, recognize both.
@bors: r+ |
📌 Commit 5fda33e has been approved by |
Add more WASI libc bindings I was writing some WASI code and needed some more bits from libc. Here's a patch adding more things from the intersection of things that WASI libc defines and things that other platforms in libc have bindings for.
Investigating this more, this has turned up some bugs in on the wasi-sysroot side, so I'm going to step back here momentarily, fix those, and them come back to this. |
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
Add more WASI libc bindings This picks up #1321, adding more WASI libc bindings, adding several more fixes. In particular, `cargo test --all` including libc-test now builds successfully.
I was writing some WASI code and needed some more bits from libc. Here's a patch adding more things from the intersection of things that WASI libc defines and things that other platforms in libc have bindings for.