Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce $CONFIG_DIR/rust-analyzer/rust-analyzer.toml #18070

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alibektas
Copy link
Member

@alibektas alibektas commented Sep 7, 2024

This PR makes the use of rust-analyzer.toml under user config directory possible. The reason why this is a draft is that some of the tests are flaky due to the way we set user config directory in our tests. Basically, to redirect server to a different path than the usual user config dir ( ~/.config/rust-analyzer/rust-analyzer.toml) we set an envvar called __TEST_RA_USER_CONFIG_DIR. During parallel executions this value gets rewritten although we use a lock to prevent this.

In short, I am looking for some help on how to fix this.

And this PR is based on another that has currently not been merged ( #18057 ) so I will kindly ask you to focus on the most recent commit ( 9f70fb3d ) only.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants