Test function imports replaced by module imports. #18464
+67
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test for rust-lang#18347. The issue affects all code using import merging. When a function and a module share the same identifier, e.g. ```rust pub fn foo() {} pub mod foo { pub fn bar() {} } ``` rust analyzer often confuses the function with the module, generating invalid code.
rustbot
added
the
S-waiting-on-review
|
I haven't been able to actually find a proper fix yet. I can't find a reliable way to tell the merging function whether an import is a module (and can be used for merging) or a function. I'm not sure if I manage to find a solution, so I'm sending a small PR with what I have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for #18347.
The issue affects all code using import merging. When a function and a module share the same identifier, e.g.
rust analyzer often confuses the function with the module, generating invalid code.