Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover config improvements #18480

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Discover config improvements #18480

wants to merge 4 commits into from
+60 −28

Conversation

bobozaur
Copy link

@bobozaur bobozaur commented Nov 5, 2024

This PR adds some small QoL improvements to the workspace.discoverConfig workflow:

  • Extends file watching beyond just the crate specific build files. Some build systems have files other scattered across the workspace that are yet worth keeping an eye on.
  • Adds a run_at_startup setting to optionally allow the discovery to take place at startup, before workspace fetching. This means though that no DiscoverArgument gets passed, which is why this defaults to false.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobozaur @rustbot