-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom attributes to fn
items
#3088
base: main
Are you sure you want to change the base?
Conversation
I'd love to add some tests as well but I'm not sure how I would do that, can't get anything other than basic tests to run. |
You can take a look at #2866, where I added some tests along with the support for custom attributes on other items ( |
I've added both regular and integration tests, CI seems to pass now as well. |
I've added the attributes from |
This PR adds functionality to add custom attributes to function items (proposed in #2978).
I've implemented this by extending the
TypeKind
used byAttributeInfo
to include theFunction(FunctionKind)
variant (seeAttributeItemKind
).Unifying the callback this way is a breaking change when
--with_attribute_custom
or matching on thekind
field is used.