Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a lintcheck specific Clippy configuration file in the CI #14233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a lintcheck specific Clippy configuration file in the CI #14233

wants to merge 1 commit into from

Conversation

samueltardieu
Copy link
Contributor

By default, lintcheck will use the clippy.toml file found at the toplevel of the repository (CARGO_MANIFEST_DIR). This file is meant for configuration of Clippy applied to Clippy sources.

This creates a new lintcheck/ci-config/clippy.toml file which is used by the CI when running lintcheck. By default this uses the default Clippy configuration.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 16, 2025
@samueltardieu samueltardieu mentioned this pull request Feb 16, 2025
Draft
@samueltardieu
Copy link
Contributor Author

r? @flip1995
since it's related to the CI

@rustbot rustbot assigned flip1995 and unassigned Jarcho Feb 17, 2025
@flip1995
Copy link
Member

I wonder if we should enable avoid-breaking-exported-api = false, in that config file, so that we get even broader lint coverage. WDYT?

@samueltardieu
Use a lintcheck specific Clippy configuration file in the CI
172d709 
By default, lintcheck will use the `clippy.toml` file found at the
toplevel of the repository (`CARGO_MANIFEST_DIR`). This file is meant
for configuration of Clippy applied to Clippy sources.

This creates a new `lintcheck/ci-config/clippy.toml` file which is used
by the CI when running lintcheck. By default this uses the default
Clippy configuration.
@samueltardieu
Copy link
Contributor Author

I wonder if we should enable avoid-breaking-exported-api = false, in that config file, so that we get even broader lint coverage. WDYT?

Let's try a run with it!

@samueltardieu
Copy link
Contributor Author

That didn't change anything for the default lintcheck run, we can let it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samueltardieu @rustbot @flip1995 @Jarcho