unnecessary_to_owned: don't call iter() on a temporary object
#14243
+71
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lapla-cogito
force-pushed
the
issue_14242
branch
from
95a5ce9 to
d8286f5
Compare
lapla-cogito
force-pushed
the
issue_14242
branch
from
d8286f5 to
9be2d63
Compare
lapla-cogito
force-pushed
the
issue_14242
branch
from
9be2d63 to
6651fac
Compare
Centri3
reviewed
Feb 22, 2025
lapla-cogito
force-pushed
the
issue_14242
branch
from
6651fac to
5a849d9
Compare
Centri3
reviewed
Feb 26, 2025
| @@ -2331,6 +2331,16 @@ pub fn is_expr_final_block_expr(tcx: TyCtxt<'_>, expr: &Expr<'_>) -> bool { | |||
| matches!(tcx.parent_hir_node(expr.hir_id), Node::Block(..)) | |||
| } | |||
|
|
|||
| /// Checks if the expression is a temporary value. | |||
| pub fn is_expr_temporary_value(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool { | |||
| expr.is_place_expr(|base| { | |||
There was a problem hiding this comment.
I think noting that this is the exact same code rustc uses would be helpful for people viewing this later. My main idea is that this looks a bit like a (maybe incorrect) heuristic at first, vs just copying the code, and this change can clear up that hypothetical confusion.
After that, I'll merge this quickly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #14242
changelog: [
unnecessary_to_owned]: don't calliteron a temporary object