Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unstable-book: Add page for the abi_efiapi feature #104793

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

nicholasbishop
Copy link
Contributor

@nicholasbishop nicholasbishop commented Nov 23, 2022

Tracking issue for abi_efiapi: #65815

@rustbot
Copy link
Collaborator

rustbot commented Nov 23, 2022

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2022
@JohnTitor
Copy link
Member

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 25, 2022

📌 Commit bed85a4 has been approved by JohnTitor

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 25, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 25, 2022
…r=JohnTitor

unstable-book: Add page for the `abi_efiapi` feature

Tracking issue for `abi_efiapi`: rust-lang#65815
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#103648 (Don't set `is_preview` for clippy and rustfmt)
 - rust-lang#104654 (Add `#![deny(unsafe_op_in_unsafe_fn)]` in liballoc tests)
 - rust-lang#104793 (unstable-book: Add page for the `abi_efiapi` feature)
 - rust-lang#104841 (Assert that we don't capture escaping bound vars in `Fn` trait selection)
 - rust-lang#104849 (Migrate source code elements style to CSS variables)
 - rust-lang#104873 (RefCell::get_mut: fix typo)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f00c3f0 into rust-lang:master Nov 25, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 25, 2022
@uweigand
Copy link
Contributor

uweigand commented Dec 6, 2022

This seems to cause a test failure on s390x (and presumably all platforms except Intel and Arm):

---- /home/uweigand/rust/src/doc/unstable-book/src/language-features/abi-efiapi.md - The_tracking_issue_for_this_feature_is__ (line 15) stdout ----
error[E0570]: `"efiapi"` is not a supported ABI for the current target

Should this be marked as ignore? (Is there a way to only ignore on certain targets?)

Part of #105383.

@nicholasbishop
Copy link
Contributor Author

@uweigand thanks for pointing that out, I put up #105390 to add ignore.

nicholasbishop added a commit to nicholasbishop/rust that referenced this pull request Dec 6, 2022
This example doesn't compile on targets that don't support UEFI, as
reported here:
rust-lang#104793 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 6, 2022
…re, r=ehuss

unstable-book: Add `ignore` to `abi_efiapi` example code

This example doesn't compile on targets that don't support UEFI, as reported here:
rust-lang#104793 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants