-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add x86 specific hotpatch flag to rustc #124966
base: master
Are you sure you want to change the base?
Conversation
@rustbot author |
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #123918) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu These commits modify compiler targets. |
…truction' condition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue about hotpatch but the tests have some issues:
This comment has been minimized.
This comment has been minimized.
Thanks for the review! The last commits have addressed the requested changes regarding tests. |
Implementation for MCP rust-lang/compiler-team#745
Add unstable ms-hotpatch option to the compiler working similar as /hotpatch in msvc
See: https://learn.microsoft.com/en-us/cpp/build/reference/hotpatch-create-hotpatchable-image?view=msvc-170&viewFallbackFrom=vs-2019
Invoking cargo with 'RUSTFLAGS="-Zhotpatch -C link-arg=-functionpadmin" cargo build --release' creates the desired outcome.
Mostly based on llvm/llvm-project@5af2433