Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x86 specific hotpatch flag to rustc #124966

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

nebulark
Copy link
Contributor

@nebulark nebulark commented May 10, 2024

Implementation for MCP rust-lang/compiler-team#745

Add unstable ms-hotpatch option to the compiler working similar as /hotpatch in msvc
See: https://learn.microsoft.com/en-us/cpp/build/reference/hotpatch-create-hotpatchable-image?view=msvc-170&viewFallbackFrom=vs-2019

Invoking cargo with 'RUSTFLAGS="-Zhotpatch -C link-arg=-functionpadmin" cargo build --release' creates the desired outcome.

Mostly based on llvm/llvm-project@5af2433

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2024
@nebulark
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@rust-log-analyzer

This comment has been minimized.

@nebulark nebulark changed the title [Experimenting] Add hotpatch flag to rustc Add hotpatch flag to rustc May 10, 2024
@nebulark nebulark changed the title Add hotpatch flag to rustc Add x86 specific hotpatch flag to rustc May 10, 2024
@bors
Copy link
Contributor

bors commented Jun 27, 2024

☔ The latest upstream changes (presumably #123918) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@apiraino
Copy link
Contributor

apiraino commented Sep 19, 2024

Waiting on compiler team to deliberate on the proposal MCP#745

@rustbot label S-waiting-on-team -S-waiting-on-author

@rustbot rustbot added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 19, 2024
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Sep 22, 2024
@nebulark nebulark marked this pull request as ready for review September 30, 2024 20:49
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2024

The run-make-support library was changed

cc @jieyouxu

This PR modifies tests/run-make/. If this PR is trying to port a Makefile
run-make test to use rmake.rs, please update the
run-make port tracking issue
so we can track our progress. You can either modify the tracking issue
directly, or you can comment on the tracking issue and link this PR.

cc @jieyouxu

These commits modify compiler targets.
(See the Target Tier Policy.)

@nebulark nebulark marked this pull request as draft October 10, 2024 19:37
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no clue about hotpatch but the tests have some issues:

tests/codegen/hotpatch.rs Outdated Show resolved Hide resolved
tests/run-make/hotpatch-unaffected/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/hotpatch/rmake.rs Outdated Show resolved Hide resolved
tests/run-make/hotpatch_pdb/rmake.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@nebulark
Copy link
Contributor Author

Thanks for the review! The last commits have addressed the requested changes regarding tests.
The PR should now be again in a state to match the current version of the MCP.

@nebulark nebulark marked this pull request as ready for review October 13, 2024 09:23
@jieyouxu jieyouxu added S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Oct 13, 2024
@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-MCP Status: PR has a compiler MCP and is waiting for the compiler MCP to complete. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants