Prereq5 for async drop - AsyncDropGlue & FutureDropPoll instances preparation #129740
+782
−1,908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes Stable MIR cc @oli-obk, @celinval, @ouz-a Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri This PR changes MIR cc @oli-obk, @RalfJung, @JakobDegen, @davidtwco, @celinval, @vakaras |
This was referenced Aug 29, 2024
azhogin
force-pushed
the
azhogin/async-drop-prereq5-instances-preparation
branch
from
6f6d305
to
8dd8360
Compare
azhogin
force-pushed
the
azhogin/async-drop-prereq5-instances-preparation
branch
from
8dd8360
to
379555a
Compare
This comment has been minimized.
This comment has been minimized.
azhogin
force-pushed
the
azhogin/async-drop-prereq5-instances-preparation
branch
from
379555a
to
175820b
Compare
|
☔ The latest upstream changes (presumably #129313) made this pull request unmergeable. Please resolve the merge conflicts. |
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-prereq5-instances-preparation
branch
from
175820b
to
62d37f8
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 5 PR of #123948, just for review purposes.
AsyncDropGlueinstance forasync_drop_in_place<T>(...)::{{closure0}}shim generation for not coroutine type.FutureDropPollinstance forasync_drop_in_place<T>(...)::{{closure0}}shim generation for coroutine type.Those have different behaviour, because for normal type we are generating normal (sync) drop glue generation using drop elaboration and then StateTransform pass for transformation into coroutine (later commits). And for coroutine we need to poll this coroutine async drop poll function with the same coroutine layout.
Review only last commit, based on previous PR #129739