Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #130615

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Rollup of 6 pull requests #130615

merged 14 commits into from
Sep 20, 2024

Commits on Sep 11, 2024

  1. Configuration menu
    Copy the full SHA
    5f72f9d View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. test: cross-edition metavar fragment specifiers

    There's a subtle interaction between macros with metavar expressions and the
    edition-dependent fragment matching behavior. This test illustrates the current
    behavior when using macro-generating-macros across crate boundaries with
    different editions.
    
    Co-Authored-By: Vincenzo Palazzo <[email protected]>
    Co-Authored-By: Eric Holk <[email protected]>
    vincenzopalazzo and eholk committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    255586d View commit details
    Browse the repository at this point in the history
  2. Add coverage for pat too

    In 2021 pat was changed to recognize `|` at the top level, with
    pat_param added to retain the old behavior. This means
    pat is subject to the same cross-edition behavior as expr will be in
    2024.
    
    Co-authored-by: Vincenzo Palazzo <[email protected]>
    eholk and vincenzopalazzo committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    7653811 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    dd6460b View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Break up compiletest runtest.rs into smaller helper modules

    Previously compiletest's `runtest.rs` was a massive 4700 lines file that
    made reading and navigation very awkward.
    
    This commit intentionally does not neatly reorganize where all the
    methods on `TestCx` goes, that is intended for a follow-up PR.
    jieyouxu committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    60600a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8745bcf View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix feature name in test

    clubby789 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e9fcb7d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98e68e5 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#129542 - zachs18:cow-self-test, r=compiler-…

    …errors
    
    Add regression test for rust-lang#129541
    
    (maybe?) closes rust-lang#129541 by adding a test that the code in question continues to compile.
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5c60185 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129755 - vincenzopalazzo:macros/recursive-m…

    …acros-between-edition, r=compiler-errors
    
    test: cross-edition metavar fragment specifiers
    
    There's a subtle interaction between macros with metavar expressions and the edition-dependent fragment matching behavior. This test illustrates the current behavior when using macro-generating-macros across crate boundaries with different editions.
    
    See the original suggestion rust-lang#123865 (comment)
    
    Tracking:
    
    - rust-lang#123742
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9cbb1cb View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#130566 - jieyouxu:breakup-runtest, r=compil…

    …er-errors
    
    Break up compiletest `runtest.rs` into smaller helper modules
    
    Previously compiletest's `runtest.rs` was a massive 4700 lines file that made reading and navigation very awkward. This PR breaks the `runtest.rs` file up into smaller helper modules, one for each test suite/mode.
    
    > [!NOTE]
    > This PR should not contain functional changes, it is intended to be mostly code motion to breakup `runtest.rs` into smaller helper modules to make it easier to digest.
    >
    > This PR intentionally does not neatly reorganize where all the methods on `TestCx` goes, that is intended for a follow-up PR. Some methods on `TestCx` do not need to be on `TestCx`. It also does not address a weirdness in valgrind, that is intended for a follow-up PR as well.
    
    Part of a series of compiletest cleanups rust-lang#130565.
    
    Fixes rust-lang#89475.
    
    r? `@ghost` (I need to do a self-review pass first)
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6a762c9 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#130585 - GuillaumeGomez:add-rustdoc-templat…

    …e-tidy-check, r=notriddle
    
    Add tidy check for rustdoc templates to ensure the whitespace characters are all stripped
    
    Fixes rust-lang#130559.
    
    I'm planning to send a follow-up in case a tag at the end of a line isn't needed (if the next line starts with a jinja tag for example).
    
    r? `@notriddle`
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3e21426 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#130605 - clubby789:change-test, r=jieyouxu

    Fix feature name in test
    
    This is meant to test that the `box_patterns` feature isn't active due to the `cfg(FALSE)`, but uses the removed `box_syntax` feature. Fix this so it's testing what it should be.
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f784c52 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#130607 - GnomedDev:remove-seekfrom-paths, r…

    …=compiler-errors
    
    [Clippy] Remove final std paths for diagnostic item
    
    Removes the paths to SeekFrom::Start/Current that were left in rust-lang#130553.
    
    This was split off as it involves introducing a utility to check for enum ctors, as both:
    - enum variants cannot be diagnostic items
    - even if they could, that wouldn't help because we need to get the enum variant ctor
    
    While adding the `is_enum_variant_ctor`, I removed both `is_diagnostic_ctor` and `is_res_diagnostic_ctor` as they are unused and never worked due to the above bullet points.
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b2bcdbc View commit details
    Browse the repository at this point in the history